adding EXPOSE command #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-builder into expose-cmd
dlorenc
reviewed
Mar 20, 2018
| func TestUpdateExposedPorts(t *testing.T) { | ||
| cfg := &manifest.Schema2Config{ | ||
| ExposedPorts: manifest.Schema2PortSet{ | ||
| "8080/tcp": {}, |
There was a problem hiding this comment.
Could you add a few test cases with udp in here as well?
priyawadhwa
reviewed
Mar 20, 2018
| // Add any new ones in | ||
| for _, p := range ports { | ||
| // Add the default protocol if one isn't specified | ||
| if !strings.Contains(p, "/") { |
There was a problem hiding this comment.
I think you may also have to make sure that a specified protocol is valid
There was a problem hiding this comment.
Should we throw an error when we find an invalid protocol? or just ignore it?
There was a problem hiding this comment.
yah, let's throw an error
dlorenc
approved these changes
Mar 20, 2018
priyawadhwa
approved these changes
Mar 20, 2018
11 tasks
priyawadhwa
added
the
area/dockerfile-command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8