Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve options when doing a cache push #423

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

carlossg
Copy link
Contributor

Otherwise options like insecure are lost

Otherwise options like `insecure` are lost
@container-tools-bot
Copy link
Collaborator

Hi @carlossg. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carlossg
Copy link
Contributor Author

For the record this moves forward allowing insecure locally deployed docker registries but doesn't make it work yet, the builds still can't find the cached image even though it is in the repo

pkg/executor/push.go Show resolved Hide resolved
@dlorenc dlorenc merged commit 5ed45ed into GoogleContainerTools:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants