Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding USER command #59

Merged
merged 6 commits into from
Mar 30, 2018
Merged

adding USER command #59

merged 6 commits into from
Mar 30, 2018

Conversation

sharifelgamal
Copy link
Contributor

Fixes #12

priyawadhwa
priyawadhwa approved these changes Mar 30, 2018
View reviewed changes
Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@priyawadhwa
Copy link
Collaborator

Actually just wondering, does this command support environment replacement?

@sharifelgamal
Copy link
Contributor Author

From what I understand, most dockerfile commands support env replacement. I can add that in quickly.

@sharifelgamal sharifelgamal merged commit c1c257f into GoogleContainerTools:master Mar 30, 2018
@priyawadhwa priyawadhwa added the area/dockerfile-command For all bugs related to dockerfile file commands label Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

Assignees
No one assigned
Labels
area/dockerfile-command For all bugs related to dockerfile file commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sharifelgamal @priyawadhwa