Added --oci-layout-path flag to save image in OCI layout.
#744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@priyawadhwa Could you take a look? Thanks! |
priyawadhwa
reviewed
Aug 21, 2019
There was a problem hiding this comment.
@chhsia0 thanks for working on this! A couple suggestions:
- Could we name the flag
--oci-layout-path - Could you add a unit test for this?
|
Sure! Is there a reference unit test I can look at as a sample? I tried to find if there's a unit test for |
chhsia0
changed the title
--layout-path flag to save image in OCI layout.--oci-layout-path flag to save image in OCI layout.
|
@priyawadhwa Done PTAL! |
|
Hmm seems this is not enough for using Kaniko in Tekton, since Tekton exports the digest of the image index itself instead of the image inside the manifest. Let me chat with the folks there to see what's the appropriate solution for this. |
|
Sounds good! |
chhsia0
force-pushed
the
layout-path
branch
2 times, most recently
from
2f64f59 to
451fa87
Compare
chhsia0
pushed a commit
to chhsia0/pipeline
that referenced
this pull request
Aug 23, 2019
…mage. Currently the image digest exporter does not implemented the behavior described in the resources doc, which says "if there are multiple versions of the image, the latest will be used." Instead, it reports the digest of `index.json`, which is an image index. This behavior introduces a usability issue: one of the major public container registry --- dockerhub --- does not support OCI image indices, and there are very few tools (if any) that support converting OCI image indices to docker manifest lists. Skopeo currently only support pushing an OCI image index that contain only one image. If the index has more than one images, it requires the user to specify one: containers/skopeo#107 containers/image#400 Essentially, these limitations make the image digest exporter useless. To make this feature useful, the exporter could instead implement the following behavior: 1. If there is only one image in `index.json`, report the image's digest. 2. If there are multiple images, report the digest of the full index. The advantage of this behavior is that, we can immediately use it (in conjunction of GoogleContainerTools/kaniko#744), yet if multi-image manifests are more widely supported, the image digest exporter can still support that without any modification.
chhsia0
pushed a commit
to chhsia0/pipeline
that referenced
this pull request
Aug 23, 2019
…ne image. Currently the image digest exporter does not implemented the behavior described in the resources doc, which says "if there are multiple versions of the image, the latest will be used." Instead, it reports the digest of `index.json`, which is an image index. This behavior introduces a usability issue: one of the major public container registry --- dockerhub --- does not support OCI image indices, and there are very few tools (if any) that support converting OCI image indices to docker manifest lists. Skopeo currently only support pushing an OCI image index that contain only one image. If the index has more than one images, it requires the user to specify one: containers/skopeo#107 containers/image#400 Essentially, these limitations make the image digest exporter useless. To make this feature useful, the exporter could instead implement the following behavior: 1. If there is only one image in `index.json`, report the image's digest. 2. If there are multiple images, report the digest of the full index. The advantage of this behavior is that, we can immediately use it (in conjunction of GoogleContainerTools/kaniko#744), yet if multi-image manifests are more widely supported, the image digest exporter can still support that without any modification.
Merged
3 tasks
|
@chhsia0 Can you please rebase? |
added 3 commits
August 24, 2019 01:04
Fixed GoogleContainerTools#296. The output manifests may have `application/vnd.docker.distribution.manifest.v2+json` as their media types instead of `application/vnd.oci.image.manifest.v1+json`.
chhsia0
force-pushed
the
layout-path
branch
2 times, most recently
from
53fe819 to
ba9b616
Compare
|
Done. |
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Sep 6, 2019
…ne image. Currently the image digest exporter does not implemented the behavior described in the resources doc, which says "if there are multiple versions of the image, the latest will be used." Instead, it reports the digest of `index.json`, which is an image index. This behavior introduces a usability issue: one of the major public container registry --- dockerhub --- does not support OCI image indices, and there are very few tools (if any) that support converting OCI image indices to docker manifest lists. Skopeo currently only support pushing an OCI image index that contain only one image. If the index has more than one images, it requires the user to specify one: containers/skopeo#107 containers/image#400 Essentially, these limitations make the image digest exporter useless. To make this feature useful, the exporter could instead implement the following behavior: 1. If there is only one image in `index.json`, report the image's digest. 2. If there are multiple images, report the digest of the full index. The advantage of this behavior is that, we can immediately use it (in conjunction of GoogleContainerTools/kaniko#744), yet if multi-image manifests are more widely supported, the image digest exporter can still support that without any modification.
|
The related PR in the Tekton project just got merged: tektoncd/pipeline#1237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #296.
The output manifests may have
application/vnd.docker.distribution.manifest.v2+jsonas their media types instead of
application/vnd.oci.image.manifest.v1+json.