Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes caching with COPY command #773

Merged
merged 12 commits into from
Nov 4, 2019

Conversation

donmccasland
Copy link
Member

@donmccasland donmccasland commented Sep 16, 2019

Fixes #742

When copying files from a snapshot or tar, when the file is listed before the parent directory, sometimes it can get copied in without the parent dir being created.

pkg/commands/copy_test.go Outdated Show resolved Hide resolved
pkg/commands/copy_test.go Outdated Show resolved Hide resolved
pkg/util/fs_util.go Outdated Show resolved Hide resolved
pkg/commands/copy_test.go Outdated Show resolved Hide resolved
pkg/commands/copy_test.go Show resolved Hide resolved
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More code changes.

pkg/commands/copy_test.go Show resolved Hide resolved
pkg/commands/copy_test.go Show resolved Hide resolved
…e being unpacked in wrong order. The problem was that the COPY command requires the FS to be unpacked before it does its work.
@donmccasland donmccasland changed the title Fixes copying files from snapshot without parent dir Fixes caching with COPY command Oct 8, 2019
Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lookin really good, just a few suggestions!

pkg/commands/copy.go Show resolved Hide resolved
pkg/commands/copy_test.go Outdated Show resolved Hide resolved
pkg/util/fs_util.go Outdated Show resolved Hide resolved
pkg/commands/copy_test.go Show resolved Hide resolved
pkg/commands/copy_test.go Show resolved Hide resolved
@priyawadhwa
Copy link
Collaborator

I think you forgot to check in Dockerfile_test_cache_copy?

@donmccasland donmccasland merged commit 56e048e into GoogleContainerTools:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsequent Builds fail when using cache
3 participants