-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes caching with COPY command #773
Merged
donmccasland
merged 12 commits into
GoogleContainerTools:master
from
donmccasland:bug-742-2
Nov 4, 2019
Merged
Fixes caching with COPY command #773
donmccasland
merged 12 commits into
GoogleContainerTools:master
from
donmccasland:bug-742-2
Nov 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…copying files out of snapshots
tejal29
suggested changes
Sep 17, 2019
tejal29
reviewed
Sep 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More code changes.
…e being unpacked in wrong order. The problem was that the COPY command requires the FS to be unpacked before it does its work.
donmccasland
changed the title
Fixes copying files from snapshot without parent dir
Fixes caching with COPY command
Oct 8, 2019
priyawadhwa
reviewed
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is lookin really good, just a few suggestions!
I think you forgot to check in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #742
When copying files from a snapshot or tar, when the file is listed before the parent directory, sometimes it can get copied in without the parent dir being created.