[WIP] Add support to download context file from Azure Blob Storage #816
Conversation
[skip ci]
…/kaniko into azure-blostorage-https
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@yangtaokm please sign the Google CLA. |
There was a problem hiding this comment.
@yangtaokm mostly nits. But the flow looks good!
Thank you for adding support to azure Storage. Do you plan to use it?
| args: ["--dockerfile=<path to Dockerfile within the build context>", | ||
| "--context=https://myaccount.blob.core.windows.net/container/path/to/context.tar.gz", | ||
| "--destination=<registry for image push>"] | ||
| ... |
There was a problem hiding this comment.
examples should point to a working yaml. Ideally users can just copy and replace the variables. Can you please remove the ...
fix formatting based on review Co-Authored-By: Tejal Desai <tejal29@gmail.com>
… into azure-blobstorage-https
|
@yangtaokm Can you please sign the Google CLA. |
|
@googlebot I fixed it |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@tejal29 thank you again for the review, suggestion and accepting the PR. We definitely will use Kaniko with Azure Blob Storage going forward. Thanks! |
Add support for downloading Build Contexts from Azure blob storage
Description
Add support for downloading Build Contexts from Azure blob storage with full blob storage url https://myaccount.blob.core.windows.net/container/path/to/context.tar.gz
Forward to azureblob.go to hand the context downloading if the --context prefixed with https:// and the url matches AzureBlobStorageHostRegEx
use Azure Storage Blob SDK for Go https://github.com/azure/azure-storage-blob-go
You will need to pass Azure Storage Account Access Key as an evironment variable named AZURE_STORAGE_ACCESS_KEY through Kubernetes Secrets
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.