-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade aws go sdk for supporting eks oidc credential chain #832
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@ffahri Can you please sign the Google CLA |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@tejal29 some packages are removed from dep is there any more tests should i run for to make sure? |
81ed92d
to
d7f917b
Compare
im having problem with logrus due to dep check out of sync. will try to fix |
d7f917b
to
b233178
Compare
@tejal29 hey updated logrus to be sync with dep check. Also updated go aws sdk to latest |
Thanks @ffahri running our integration tests now. |
Looks like some integration tests failed
|
b233178
to
16b4f70
Compare
rebased against master and updated the change to use go modules |
Upgrading aws go sdk to support eks oidc for iam.
This way kaniko can use oidc service accounts to push images to ecr
#826