Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aws go sdk for supporting eks oidc credential chain #832

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

ffahri
Copy link
Contributor

@ffahri ffahri commented Oct 23, 2019

Upgrading aws go sdk to support eks oidc for iam.
This way kaniko can use oidc service accounts to push images to ecr

#826

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tejal29
Copy link
Contributor

tejal29 commented Oct 24, 2019

@ffahri Can you please sign the Google CLA

@ffahri
Copy link
Contributor Author

ffahri commented Oct 24, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ffahri
Copy link
Contributor Author

ffahri commented Oct 24, 2019

@tejal29 some packages are removed from dep is there any more tests should i run for to make sure?

@ffahri ffahri force-pushed the upgrade-aws-go-sdk branch 2 times, most recently from 81ed92d to d7f917b Compare October 25, 2019 18:49
@ffahri
Copy link
Contributor Author

ffahri commented Oct 25, 2019

im having problem with logrus due to dep check out of sync. will try to fix

@ffahri ffahri force-pushed the upgrade-aws-go-sdk branch from d7f917b to b233178 Compare October 26, 2019 10:31
@ffahri
Copy link
Contributor Author

ffahri commented Oct 26, 2019

@tejal29 hey updated logrus to be sync with dep check. Also updated go aws sdk to latest

@tejal29
Copy link
Contributor

tejal29 commented Nov 7, 2019

Thanks @ffahri running our integration tests now.

@tejal29
Copy link
Contributor

tejal29 commented Nov 7, 2019

Looks like some integration tests failed

 --- FAIL: TestRun/test_Dockerfile_test_multistage (10.36s)
        integration_test.go:224: diff = [
              {
                "Image1": "gcr.io/kaniko-test/docker-dockerfile_test_multistage",
                "Image2": "gcr.io/kaniko-test/kaniko-dockerfile_test_multistage",
                "DiffType": "File",
                "Diff": {
                  "Adds": [
                    {
                      "Name": "/dockerfiles/Dockerfile_test_cache_copy",
                      "Size": 64
                    }
                  ],
                  "Dels": null,
                  "Mods": [
                    {
                      "Name": "/images.go",
                      "Size1": 10748,
                      "Size2": 10787
                    },
                    {
                      "Name": "/date",
                      "Size1": 29,
                      "Size2": 29
                    }
                  ]
                }
              },
              {
                "Image1": "gcr.io/kaniko-test/docker-dockerfile_test_multistage",
                "Image2": "gcr.io/kaniko-test/kaniko-dockerfile_test_multistage",
                "DiffType": "Metadata",
                "Diff": {
                  "Adds": [],
                  "Dels": []
                }
              }
            ]
        integration_test.go:227: []integration.diffOutput differ (-got, +want): {[]integration.diffOutput}[0].Diff.Adds:
            	-: []integration.fileDiff{{Name: "/dockerfiles/Dockerfile_test_cache_copy", Size: 64}}
            	+: []integration.fileDiff(nil)

@cvgw cvgw force-pushed the upgrade-aws-go-sdk branch from b233178 to 16b4f70 Compare December 21, 2019 22:56
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Dec 21, 2019
@cvgw
Copy link
Contributor

cvgw commented Dec 21, 2019

rebased against master and updated the change to use go modules

@cvgw cvgw merged commit 8154046 into GoogleContainerTools:master Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants