Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme known issues #874

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Nov 21, 2019

Fixes #865 #864

Description
Update Readme

  • clarifying which Docker images are support for running kaniko (only the official image)
  • kaniko does not support v1 registry api

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

* Know Issues
  * kaniko in non-official images
  * v1 Registry Schema
@cvgw cvgw force-pushed the u/cgwippern/update_doc_images_registries branch from f6ac936 to 02db3c1 Compare November 21, 2019 20:58
@cvgw cvgw requested a review from priyawadhwa November 21, 2019 20:59
Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cvgw cvgw merged commit d6f1ec1 into GoogleContainerTools:master Nov 22, 2019
@cvgw cvgw deleted the u/cgwippern/update_doc_images_registries branch November 22, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation: Kaniko only support in official kaniko docker image
2 participants