Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contribution issue sentence #912

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 11, 2019

Description

The contribution page bullet didn't make sense as is. I considered filing a bug, but tbh because of the sentence as is, I can't tell if I needed to or not. I've decided that I probably don't need to, and since the fix is so short, it feels like just offering it is better than filing an issue on the point.

Submitter Checklist

See the contribution guide for more details.

Note: I read the contributing guide, none of the changes I'm making involve code, which is why I've removed the checkboxes. And ... well, the contributing guide is confusing. But, I'm trying :-)

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- Skaffold config changes like
  e.g. "Add buildArgs to `Kustomize` deployer skaffold config."
- Bug fixes
  e.g. "Improve skaffold init behaviour when tags are used in manifests"
- Any changes in skaffold behavior
  e.g. "Artiface cachine is turned on by default."

CONTRIBUTING.md Show resolved Hide resolved
@tejal29 tejal29 merged commit d72a960 into GoogleContainerTools:master Dec 13, 2019
@jsoref jsoref deleted the contributing-if-exists branch December 14, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants