Fix #926 cache warmer and method signature #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvgw
force-pushed
the
u/cgwippern/issue-926_fix_cache_warmer_and_method_sig
branch
4 times, most recently
from
ae9072b
to
56232d6
Compare
tejal29
reviewed
Dec 23, 2019
cvgw
force-pushed
the
u/cgwippern/issue-926_fix_cache_warmer_and_method_sig
branch
from
56232d6
to
2fc44a3
Compare
4 tasks
cvgw
force-pushed
the
u/cgwippern/issue-926_fix_cache_warmer_and_method_sig
branch
from
2fc44a3
to
776fa43
Compare
tejal29
approved these changes
Jan 10, 2020
cvgw
deleted the
u/cgwippern/issue-926_fix_cache_warmer_and_method_sig
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #926 .
Description
A previous change had broken the cache warmer by updating the return signature of a method which the cache warmer called.
This fixes that issue, refactors the warming code for easier testing, and adds unit tests.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.