-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run integration tests in Travis CI #979
Run integration tests in Travis CI #979
Conversation
- Change integration tests to use docker hub instead of GCR due to bug in library that requires authentication with gcr.io even for public images. See GoogleContainerTools#966 for bug tracking this. - Make uploading to GCS bucket configurable through a flag --uploadToGCS - Utilize a locally deployed docker registry in travis CI to remove dependency of needing to authenticate with GCP. This requires host networking such that we can access the registry on localhost:5000 - Use the commit that's being tested for `TestGitBuildcontext` - Remove duplicate GitBuildContext case that's now covered by default in travis CI.
9ac0de5
to
61af994
Compare
@@ -1,4 +1,4 @@ | |||
FROM gcr.io/distroless/base@sha256:628939ac8bf3f49571d05c6c76b8688cb4a851af6c7088e599388259875bde20 | |||
FROM debian:10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to change this one from distroless/base to debian?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there is no reason to use distroless for the test case. Distroless is only available on GCR and there is an issue with GCR when you're not authenticated with gcloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍
This is great!! Would you be able to do this in this PR ? or want to follow up in another PR? |
Let's separate that in another PR. I think 20 mins is still acceptable for a full integration testing run since previously it was only running unit tests. |
also I suggest to keep kokoro running for the the next few weeks at least. This way we can easily see whether some issues might not be catched with a local registry vs using gcr. |
in library that requires authentication with gcr.io even for public
images. See kaniko requires authentication for base images that are in gcr.io #966 for bug tracking this.
dependency of needing to authenticate with GCP. This requires host
networking such that we can access the registry on localhost:5000
TestGitBuildcontext
travis CI.
Related to #947
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes