Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer platform that is currently running for pulling remote images and kaniko binary Makefile target #980

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

PhoenixMage
Copy link
Contributor

Fixes #646 rebase.

I needed this for my arm64 k8s cluster. I have zero Go experience but
enough experience with other things to fix the rebase (I think!). This
patch is working fine on my cluster.

I needed this for my arm64 k8s cluster. I have zero Go experience but
enough experience with other things to fix the rebase (I think!). This
patch is working fine on my cluster.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed by all commit authors label Jan 20, 2020
@PhoenixMage
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Jan 20, 2020
@tejal29
Copy link
Contributor

tejal29 commented Jan 21, 2020

Thanks @PhoenixMage since you had to rebase this multiple times last time you raised this PR, i really want to get this in sooner :)
I fixed the lint error and ran integration tests.

@tejal29 tejal29 changed the title Rebase fix for PR #646 Prefer platform that is currently running for pulling remote images and kaniko binary Makefile target Jan 22, 2020
@tejal29 tejal29 merged commit 6a6c547 into GoogleContainerTools:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants