Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #519 capital letter in stage names #983

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Jan 20, 2020

Fixes #519

Description

update stage code so that when comparing the BaseName of a stage against the recorded, lowercase version of a Stage name the BaseName is also lowercased.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- fix bug with uppercase stage names

update stage code so that when comparing the BaseName of
a stage against the recorded, lowercase version of a Stage name
the BaseName is also lowercased.
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Jan 20, 2020
@cvgw cvgw requested review from samos123 and tejal29 January 21, 2020 00:15
@tejal29 tejal29 merged commit 649a0ed into GoogleContainerTools:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'could not parse reference' for cached builds with UPPERCASE stage names
3 participants