-
Notifications
You must be signed in to change notification settings - Fork 40
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve applier and status synchronization
- Fix Syncing condition errors to include errors from all reconciler pipeline phases: rendering, source, & sync. - Centralize aggregation of sync errors in `updater.status()` - Move the periodic sync status update from the reconciler into the parser. This removes the need for some synchronization that wasn't previously thread-safe. - Use locks to protect the MultiError, Syncing, and Apply methods independently. This is a hack to improve thread-safety without changing the Applier interface. In the future, the interface should probably be rewritten to use channels instead. - Remove obsolete parser methods - Clean up period constants - Rename applier.Interface to KptApplier to make way for the KptDestroyer interface later. - Set ErrorSummary fields to nil when empty (no errors) - Fix e2e ValidateReconcilerErrors to allow missing Sync metric if a Source metric is expected, now that setSyncStatus is skipped when there are no updates. Change-Id: I28d767388ef9da2f7bb6484d6bad8e903e23e461
- Loading branch information
Showing
24 changed files
with
1,137 additions
and
740 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.