Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ClusterRoleOverrideSpec to v1alpha #1021

Merged

Conversation

sdowell
Copy link
Contributor

@sdowell sdowell commented Nov 10, 2023

This API was added to v1beta but not v1alpha, and did not have any conversion code added. This API is intended to be replaced by the roleRefs API, but this will fix clientgen in the interim.

Will be replaced by #991, but this fixes clientgen in the interim

This API was added to v1beta but not v1alpha, and did not have any
conversion code added. This API is intended to be replaced by the
roleRefs API, but this will fix clientgen in the interim.
Copy link
Contributor

@karlkfi karlkfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b35c049 into GoogleContainerTools:main Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants