Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add BYOID support for OCI artifacts and Helm charts #1121

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

nan-yu
Copy link
Contributor

@nan-yu nan-yu commented Feb 1, 2024

This commit integrates BYOID support into Config Sync by supporting a new auth type for OCI and Helm: k8sserviceaccount. It requires GKE or Fleet Workload Identity to be enabled. The KSA along with WI will be exchanged to a federated token which can be used to authenticate to Ubermint-enabled GCP services directly.

@nan-yu nan-yu requested review from sdowell and janetkuo and removed request for haiyanmeng February 1, 2024 18:58
@nan-yu
Copy link
Contributor Author

nan-yu commented Feb 2, 2024

There is no dependency for this PR. It is ready for another look.

@nan-yu nan-yu force-pushed the main branch 2 times, most recently from 0c4ef9a to 0157f3e Compare February 2, 2024 20:13
@nan-yu nan-yu force-pushed the main branch 2 times, most recently from 6a2f1d9 to b862af2 Compare February 2, 2024 22:31
@nan-yu nan-yu force-pushed the main branch 2 times, most recently from 9f27814 to 4615898 Compare February 2, 2024 23:23
Copy link
Contributor

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@sdowell sdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This commit integrates BYOID support into Config Sync by supporting a
new auth type for OCI and Helm: `k8sserviceaccount`. It requires GKE or
Fleet Workload Identity to be enabled. The KSA along with WI will be
exchanged to a federated token which can be used to authenticate to
Ubermint-enabled GCP services directly.
@janetkuo
Copy link
Contributor

janetkuo commented Feb 2, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 2, 2024
@google-oss-prow google-oss-prow bot merged commit 1d50f52 into GoogleContainerTools:main Feb 2, 2024
6 checks passed
nan-yu added a commit to nan-yu/kpt-config-sync that referenced this pull request Feb 5, 2024
…ontainerTools#1121)

This commit integrates BYOID support into Config Sync by supporting a
new auth type for OCI and Helm: `k8sserviceaccount`. It requires GKE or
Fleet Workload Identity to be enabled. The KSA along with WI will be
exchanged to a federated token which can be used to authenticate to
Ubermint-enabled GCP services directly.
nan-yu added a commit to nan-yu/kpt-config-sync that referenced this pull request Feb 5, 2024
…ontainerTools#1121)

This commit integrates BYOID support into Config Sync by supporting a
new auth type for OCI and Helm: `k8sserviceaccount`. It requires GKE or
Fleet Workload Identity to be enabled. The KSA along with WI will be
exchanged to a federated token which can be used to authenticate to
Ubermint-enabled GCP services directly.
nan-yu added a commit to nan-yu/kpt-config-sync that referenced this pull request Feb 5, 2024
…ontainerTools#1121)

This commit integrates BYOID support into Config Sync by supporting a
new auth type for OCI and Helm: `k8sserviceaccount`. It requires GKE or
Fleet Workload Identity to be enabled. The KSA along with WI will be
exchanged to a federated token which can be used to authenticate to
Ubermint-enabled GCP services directly.
tiffanny29631 pushed a commit to tiffanny29631/kpt-config-sync that referenced this pull request Feb 5, 2024
…ontainerTools#1121)

This commit integrates BYOID support into Config Sync by supporting a
new auth type for OCI and Helm: `k8sserviceaccount`. It requires GKE or
Fleet Workload Identity to be enabled. The KSA along with WI will be
exchanged to a federated token which can be used to authenticate to
Ubermint-enabled GCP services directly.
nan-yu added a commit to nan-yu/kpt-config-sync that referenced this pull request Feb 6, 2024
…ontainerTools#1121)

This commit integrates BYOID support into Config Sync by supporting a
new auth type for OCI and Helm: `k8sserviceaccount`. It requires GKE or
Fleet Workload Identity to be enabled. The KSA along with WI will be
exchanged to a federated token which can be used to authenticate to
Ubermint-enabled GCP services directly.
google-oss-prow bot pushed a commit that referenced this pull request Feb 7, 2024
This commit integrates BYOID support into Config Sync by supporting a
new auth type for OCI and Helm: `k8sserviceaccount`. It requires GKE or
Fleet Workload Identity to be enabled. The KSA along with WI will be
exchanged to a federated token which can be used to authenticate to
Ubermint-enabled GCP services directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants