Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the source spec validation #1122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor the source spec validation #1122

wants to merge 1 commit into from
+978 −594

Commits on Feb 7, 2024

  1. Loosen the validation around unused field 

    When fields in RSync spec is not used, some are allowed to be present,
such as `spec.git`, `spec.oci`, `spec.helm`, and
`spec.xxx.gcpServiceAccountEmail`. However, `spec.xxx.secretRef` is not
allowed when it is not used. The reconciler-manager already checks if it
is the proper auth type before copying to the config-management-system
Namespace, so it is okay to loosen the validation for this field.

This commit also refactors the auth types to reduce code duplication.
    @nan-yu
    nan-yu committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c3fb6b1 View commit details
    Browse the repository at this point in the history