[metric] #2 Revert declared_resources metric name #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiffanny29631
changed the title
tiffanny29631
changed the title
tiffanny29631
changed the title
tiffanny29631
changed the title
tiffanny29631
force-pushed
the
declared-resource-name
branch
3 times, most recently
from
61daba5
to
48136d5
Compare
nan-yu
reviewed
May 30, 2024
tiffanny29631
force-pushed
the
declared-resource-name
branch
2 times, most recently
from
d507a9d
to
2460d7b
Compare
nan-yu
reviewed
May 31, 2024
tiffanny29631
force-pushed
the
declared-resource-name
branch
from
2460d7b
to
b43b795
Compare
The metric name was changed to `declared_resources_total` using the metricstransform processor without communicating in the documentation / release note and the intention was unclear. This change reverts the name change and adds e2e test around all the [available metrics](http://cloud/kubernetes-engine/enterprise/config-sync/docs/how-to/monitoring-config-sync) in GCM. The check skips the counter metrics for now as they have no data when no error condition has happened.
tiffanny29631
force-pushed
the
declared-resource-name
branch
from
b43b795
to
f33f012
Compare
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nan-yu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 1c018a0
into
GoogleContainerTools:main
6 checks passed
tiffanny29631
added a commit
to tiffanny29631/kpt-config-sync
that referenced
this pull request
Jun 5, 2024
…#1235) The metric name was changed to `declared_resources_total` using the metricstransform processor without communicating in the documentation / release note and the intention was unclear. This change reverts the name change and adds e2e test around all the [available metrics](http://cloud/kubernetes-engine/enterprise/config-sync/docs/how-to/monitoring-config-sync) in GCM. The check skips the counter metrics for now as they have no data when no error condition has happened.
google-oss-prow bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
The metric name was changed to `declared_resources_total` using the metricstransform processor without communicating in the documentation / release note and the intention was unclear. This change reverts the name change and adds e2e test around all the [available metrics](http://cloud/kubernetes-engine/enterprise/config-sync/docs/how-to/monitoring-config-sync) in GCM. The check skips the counter metrics for now as they have no data when no error condition has happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric name was changed to
current_declared_resourcesusing the metricstransform processor without communicating in the documentation / release note and the intention was unclear.This change reverts the name change and adds e2e test around all the available metrics in GCM. The check skips the counter metrics for now as they have no data when no error condition has happened.