Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add watch filtering by package-id label (obsolete) #1239

Closed
wants to merge 1 commit into from

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented May 30, 2024

go/config-sync-watch-filter

Dependencies:

TODO:

  • Extract SyncStatusUpdater changes
  • Extract conflict handler changes
  • Finalize design approval (some open questions about label naming)

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from karlkfi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from nan-yu and sdowell May 30, 2024 00:47
@karlkfi karlkfi force-pushed the karl-watch-filter branch 3 times, most recently from 3843a4f to 5082e7f Compare June 5, 2024 22:35
go/config-sync-watch-filter
@karlkfi karlkfi changed the title [WIP] Add watch filtering by package-id label [WIP] Add watch filtering by package-id label (obsolete) Jul 4, 2024
@karlkfi
Copy link
Contributor Author

karlkfi commented Jul 4, 2024

This PR is replaced by #1301, which has less tech debt in it. But I'm going to keep this one open and blocked for a bit so I can mine it for refactoring to do after watch filtering merges.

@karlkfi karlkfi closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant