Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s to v1.30 #1302

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Jul 3, 2024

  • k8s.io/kubernetes v1.30.1
  • sigs.k8s.io/controller-runtime v0.18.4
  • github.com/open-policy-agent/cert-controller v0.10.2+
    Using HEAD to pull in compatibility with controller-runtime v0.18.

Dependencies:

@karlkfi karlkfi requested a review from sdowell July 3, 2024 00:45
@karlkfi karlkfi force-pushed the karl-k8s-1.30 branch 2 times, most recently from a11a4ea to 5216bd2 Compare July 3, 2024 22:37
@karlkfi
Copy link
Contributor Author

karlkfi commented Jul 3, 2024

I don't really understand why, but go-licenses is now erroring with Non go modules projects are no longer supported. errors on a lot of go stdlib packages. AFAIK, that requirement was added in go-licenses v1.1.0. So I don't know what changed in this PR to trigger a new error from the same version of go-licenses.

Update: Fixed by #1308

@karlkfi karlkfi changed the title Update Go, kubernetes, controller-runtime, etc. Update kubernetes, controller-runtime, etc. Jul 8, 2024
@karlkfi
Copy link
Contributor Author

karlkfi commented Jul 8, 2024

/hold

Gonna make another PR to upgrade k8s to 1.29 first

@karlkfi karlkfi changed the title Update kubernetes, controller-runtime, etc. Update k8s to v1.30 Jul 8, 2024
go.mod Outdated Show resolved Hide resolved
- k8s.io/kubernetes v1.30.1
- sigs.k8s.io/controller-runtime v0.18.4
- github.com/open-policy-agent/cert-controller v0.10.2+
  Using HEAD to pull in compatibility with controller-runtime v0.18.
@karlkfi
Copy link
Contributor Author

karlkfi commented Jul 8, 2024

/unhold

Copy link
Contributor

@sdowell sdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2182b7e into GoogleContainerTools:main Jul 8, 2024
6 checks passed
@karlkfi karlkfi deleted the karl-k8s-1.30 branch July 8, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants