Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey TestInvalidR*SyncBranchStatus #274

Merged

Commits on Nov 10, 2022

  1. Fix flakey TestInvalidR*SyncBranchStatus

    - The test is waiting for the reconciler_errors metric to be recorded
      for both source and sync status, but if there is a source error,
      the sync status won't be updated and the metric won't be sent for
      the sync component.
    - The only reason this works today is that the async calls to
      setSyncStatus aren't being deduped. Once they're deduped, this
      flakiness would become consistent failure. So this fix helps
      unblock  additional synchronization fixes.
    
    Change-Id: Idd2e9df8ef96bc568e1cb7dac791659464057c3f
    karlkfi committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    8dcd46a View commit details
    Browse the repository at this point in the history