Commits on Nov 15, 2022

1. Simplify status reporting of sync errors …

   - Add a new setSyncStatus that handles:
     - Updating the cached sync status in `state`
     - Checking the cached sync status to avoid unnecessary updates
     - Calling SetSyncStatus with the new sync errors
     - Calling reportRootSyncConflicts to update remote RootSyncs, if
       they are causing conflicts with the current RSync.
   - Rename UpdateConflictManagerStatus -> reportRootSyncConflicts
   - Rename parse.setXStatus -> setXStatusFields to allow the name
     setSyncStatus to be used by the wrapper that handles state
   - Call the new parse.setSyncStatus to make all the updates
     consistent, instead of calling parser.SetSyncStatus directly.
   - Rename updateSyncStatus -> updateSyncStatusPeriodically to
     indicate it handles retrying until cancelled.
   - Rename Parser.ApplierErrors() -> SyncErrors() and have it
     delegate to the new updater.Errors(), which centralizes
     aggregation of the following errors that are all reported as
     sync errors:
     - Remediator conflict errors
     - Validation errors from updating the object set
     - Applier errors
     - Watch update errors
   - Remove Parser.RemediatorConflictErrors() because it's obsolete
     with the new SyncErrors. The conflict errors are a subset of the
     sync errors and are extracted as-needed in setSyncErrors.
     This extraction probably won't be necessary in the future, as we
     plan to stop reporting errors across RSyncs.
   - Enhance TestConflictingDefinitions_RootToRoot to handle catching
     conflict errors in parallel, for speed and consistently.
   - Enahance TestDontDeleteAllNamespaces to use WatchForObject
   - Fix linter copylock error
   
   Change-Id: I79aa32d22080bc91a4262279de0b490974564112

   

   karlkfi committed Nov 15, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 0924850
   • Browse repository at this point

   Copy the full SHA

   0924850 View commit details

   Browse the repository at this point in the history