Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve thread-safety of sync status updates #301

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Improve thread-safety of sync status updates #301

merged 1 commit into from
Nov 17, 2022

Commits on Nov 16, 2022

  1. Improve thread-safety of sync status updates 

    - Wrap applier errors in their own mutex
- Move applier.Syncing() to Parser.Syncing() with updater.Updating()
  doing the heavy lifting. The Syncing condition status should
  reflect the whole updater, not just the applier.
- Rename applier.Interface -> KptApplier to make room for adding
  KptDestroyer in the future.
- Rename KptApplier.sync -> applyInner to make room for adding
  destroyInner in the future.
- Refactor state.syncStatus and Parser.SetSyncStatus to use a new
  syncStatus struct, which is like the sourceStatus struct but with
  an added sync bool. This should also be less confusing, because
  state.syncStatus no longer uses a sourceStatus struct as its value.
- Add a new setSyncStatusErrors func to use in
  prependRootSyncRemediatorStatus, to avoid needing to to re-construct
  the initial syncStatus when prepending errors.

Change-Id: Ib4316b8094c371d9371e7bb48bd3b309e668a78b
    @karlkfi
    karlkfi committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    fd90da8 View commit details
    Browse the repository at this point in the history