Remove the logic for setting the nested protocol field in k8s objects containing an array of ports.
#416
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
containing an array of `ports`. The logic was added in March 2021 as a workaround for a known k8s issue, which causes getting the declared fields for k8s objects containing an array of `ports` to fail. The fixes to the k8s issue have been merged into k8s 1.20 and 1.21: 1) kubernetes/kubernetes#96317 (merged in 1.20) 2) kubernetes/kubernetes#98576 (merged in 1.21). k8s 1.21 is no longer supported on GKE and Anthos: 1) GKE release schedule: https://cloud.google.com/kubernetes-engine/docs/release-schedule 2) Anthos version and upgrade support: https://cloud.google.com/anthos/docs/version-and-upgrade-support Therefore, we can remove the logic and related unit tests. We can keep the e2e test to make sure this change does not break things.
haiyanmeng
force-pushed
the
default-protocol
branch
from
550e87a
to
2dd18de
Compare
|
@haiyanmeng: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Please ignore my message. I'm just testing prow settings in the repo. |
|
Is this WIP? If it is consider closing the PR and keeping the private branch or converting to draft. |
The logic was added in March 2021 as a workaround for a known k8s issue, which causes getting the declared fields for k8s objects containing an array of
portsto fail. The fixes to the k8s issue have been merged into k8s 1.20 and 1.21:Integrate defaults marker to defaulter-gen kubernetes/kubernetes#96317 (merged in 1.20)
Fix SSA for APIService kubernetes/kubernetes#98576 (merged in 1.21).
k8s 1.21 is no longer supported on GKE and Anthos:
GKE release schedule: https://cloud.google.com/kubernetes-engine/docs/release-schedule
Anthos version and upgrade support: https://cloud.google.com/anthos/docs/version-and-upgrade-support
Therefore, we can remove the logic and related unit tests. We can keep the e2e test to make sure this change does not break things.