Apply suggestions from code review

Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com>

pkg/skaffold/deploy/helm/helm.go

@@ -261,7 +261,8 @@ func (h *Deployer) Deploy(ctx context.Context, out io.Writer, builds []graph.Art
 
 	olog.Entry(ctx).Infof("Deploying with helm v%s ...", h.bV)
 
-	// Build dependency graph
+// Build dependency graph to determine the order of Helm release deployments.
+	dependencyGraph, err := BuildDependencyGraph(h.Releases)
 	dependencyGraph, err := BuildDependencyGraph(h.Releases)
 	if err != nil {
 		return fmt.Errorf("error building dependency graph: %w", err)
@@ -282,7 +283,8 @@ func (h *Deployer) Deploy(ctx context.Context, out io.Writer, builds []graph.Art
 	nsMap := map[string]struct{}{}
 	manifests := manifest.ManifestList{}
 
-	// Group releases by their dependency level
+// Group releases by their dependency level to deploy them in the correct order.
+	levelGroups := groupReleasesByLevel(deploymentOrder, dependencyGraph)
 	levelGroups := groupReleasesByLevel(deploymentOrder, dependencyGraph)
 
 	g, levelCtx := errgroup.WithContext(ctx)
@@ -698,7 +700,8 @@ func (h *Deployer) warnAboutUnusedImages(builds []graph.Artifact, manifests mani
 	}
 }
 
-// calculateDeploymentOrder returns a topologically sorted list of releases
+// calculateDeploymentOrder returns a topologically sorted list of releases,
+// ensuring that releases are deployed after their dependencies.
 func calculateDeploymentOrder(graph map[string][]string) ([]string, error) {
 	visited := make(map[string]bool)
 	var order []string

pkg/skaffold/schema/latest/config.go

@@ -1071,7 +1071,7 @@ type HelmRelease struct {
 	// Packaged parameters for packaging helm chart (`helm package`).
 	Packaged *HelmPackaged `yaml:"packaged,omitempty"`
 
-	// DependsOn is a list of Helm releases that this deploy depends on.
+	// DependsOn is a list of Helm release names that this deploy depends on.
 	DependsOn []string `yaml:"dependsOn,omitempty"`
 }