-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ** glob pattern in sync parameters #1266
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
40c2edb
to
dd9be9e
Compare
@pehlert can you please rebase and sign the CLA? This looks good, I'm open to merge it. |
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
+ Coverage 44.24% 44.26% +0.02%
==========================================
Files 104 104
Lines 4629 4631 +2
==========================================
+ Hits 2048 2050 +2
Misses 2372 2372
Partials 209 209
Continue to review full report at Codecov.
|
@balopat Took some back and forth as I didn't have a Windows box available for testing, but should be okay now. |
would be nice if this could be merged for the next release 👍 |
@radityasurya thanks for your contribution! |
This change allows to use the doublestar (**) pattern in the sync parameters for recursive sync of deep folder structures.
It will hopefully not break compatibility with existing use cases, but as I only started working with skaffold, I cannot guarantee this. Test cases are still passing at least.
If desired, I can also add a new example illustrating the use of this.
Syntax example: