Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ** glob pattern in sync parameters #1266

Merged
merged 2 commits into from
Nov 20, 2018

Conversation

pehlert
Copy link
Contributor

@pehlert pehlert commented Nov 11, 2018

This change allows to use the doublestar (**) pattern in the sync parameters for recursive sync of deep folder structures.

It will hopefully not break compatibility with existing use cases, but as I only started working with skaffold, I cannot guarantee this. Test cases are still passing at least.

If desired, I can also add a new example illustrating the use of this.

Syntax example:

sync:
    app/src/**/*.js: app/src
    app/css/**/*.css: app/css
    html/*.html: static/

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@balopat
Copy link
Contributor

balopat commented Nov 16, 2018

@pehlert can you please rebase and sign the CLA? This looks good, I'm open to merge it.

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

Codecov Report

Merging #1266 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
+ Coverage   44.24%   44.26%   +0.02%     
==========================================
  Files         104      104              
  Lines        4629     4631       +2     
==========================================
+ Hits         2048     2050       +2     
  Misses       2372     2372              
  Partials      209      209
Impacted Files Coverage Δ
pkg/skaffold/sync/sync.go 91.17% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d808c...76e81ed. Read the comment docs.

@pehlert
Copy link
Contributor Author

pehlert commented Nov 17, 2018

@balopat Took some back and forth as I didn't have a Windows box available for testing, but should be okay now.

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Nov 19, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 19, 2018
@radityasurya
Copy link

would be nice if this could be merged for the next release 👍

@priyawadhwa priyawadhwa merged commit 3902445 into GoogleContainerTools:master Nov 20, 2018
@priyawadhwa
Copy link
Contributor

@radityasurya thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants