Add custom build arguments in jib artifacts #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
+ Coverage 46.95% 46.97% +0.02%
==========================================
Files 119 119
Lines 5143 5145 +2
==========================================
+ Hits 2415 2417 +2
Misses 2480 2480
Partials 248 248
Continue to review full report at Codecov.
|
dgageot
suggested changes
Feb 6, 2019
There was a problem hiding this comment.
@corneliusweig Can you rename mavenArgs and gradleArgs to args?
balopat
approved these changes
Feb 8, 2019
corneliusweig
force-pushed
the
jib-args
branch
from
a24de07
to
7a2c583
Compare
added 2 commits
February 12, 2019 13:36
Before, there was no way to pass custom arguments to the jib artifacts. Now, there is the `mavenArgs` and `gradleArgs` field which expect a list of strings which is forwarded to the maven and gradle builder, respectively. Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
corneliusweig
force-pushed
the
jib-args
branch
from
7a2c583
to
78bd619
Compare
dgageot
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, there was no way to pass custom arguments to the jib artifacts.
Now, there is the
mavenArgsandgradleArgsfield which expect a list of strings which is forwarded to the maven and gradle builder, respectively.Fixes #1565