-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom build arguments in jib artifacts #1609
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
+ Coverage 46.95% 46.97% +0.02%
==========================================
Files 119 119
Lines 5143 5145 +2
==========================================
+ Hits 2415 2417 +2
Misses 2480 2480
Partials 248 248
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corneliusweig Can you rename mavenArgs
and gradleArgs
to args
?
a24de07
to
7a2c583
Compare
Before, there was no way to pass custom arguments to the jib artifacts. Now, there is the `mavenArgs` and `gradleArgs` field which expect a list of strings which is forwarded to the maven and gradle builder, respectively. Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
7a2c583
to
78bd619
Compare
Before, there was no way to pass custom arguments to the jib artifacts.
Now, there is the
mavenArgs
andgradleArgs
field which expect a list of strings which is forwarded to the maven and gradle builder, respectively.Fixes #1565