Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native zsh completion script generator #3137

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Use native zsh completion script generator #3137

merged 2 commits into from
Nov 6, 2019

Commits on Oct 29, 2019

  1. Use native zsh completion script generator 

    So far, Skaffold used a wrapper code borrowed from kubectl to use the bash completion script for zsh. Cobra v0.0.5 introduced a native completion script generator for zsh. To support the `source <(...)` use-case, a minor tweak is necessary (also see spf13/cobra#887)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
    @corneliusweig
    corneliusweig committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    eb00885 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Do not explicitly ignore write errors

    @corneliusweig
    corneliusweig committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    0f4466d View commit details
    Browse the repository at this point in the history