Cobra context #3842

dgageot · 2020-03-19T19:37:22Z

Simplify context handling using cmd.Context()

Signed-off-by: David Gageot <david@gageot.net>

codecov · 2020-03-20T08:27:57Z

Codecov Report

Merging #3842 into master will increase coverage by 0.01%.
The diff coverage is 76.19%.

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/init.go	`100% <ø> (ø)`	⬆️
cmd/skaffold/app/cmd/deploy.go	`80.64% <ø> (ø)`	⬆️
cmd/skaffold/app/cmd/dev.go	`86.66% <ø> (ø)`	⬆️
cmd/skaffold/app/signals.go	`100% <ø> (ø)`
cmd/skaffold/app/cmd/render.go	`42.1% <ø> (ø)`	⬆️
cmd/skaffold/app/cmd/generate_pipeline.go	`57.14% <ø> (ø)`	⬆️
cmd/skaffold/app/cmd/build.go	`82.5% <ø> (ø)`	⬆️
cmd/skaffold/app/cmd/schema.go	`80% <0%> (ø)`	⬆️
cmd/skaffold/app/cmd/fix.go	`67.74% <0%> (ø)`	⬆️
cmd/skaffold/app/cmd/credits/export.go	`0% <0%> (ø)`	⬆️
... and 13 more

dgageot requested review from balopat, nkubala and tejal29 as code owners March 19, 2020 19:37

pull-request-size bot added the size/L label Mar 19, 2020

googlebot added the cla: yes label Mar 19, 2020

dgageot force-pushed the cobra-context branch from ea2e425 to 1d7d084 Compare March 20, 2020 08:19

dgageot added 2 commits March 20, 2020 09:19

Update cobra to 0.6.0

d174bf2

Signed-off-by: David Gageot <david@gageot.net>

Simplify context handling

9d2ca76

Signed-off-by: David Gageot <david@gageot.net>

dgageot force-pushed the cobra-context branch from 1d7d084 to 9d2ca76 Compare March 20, 2020 08:19

balopat approved these changes Mar 22, 2020

View reviewed changes

dgageot merged commit cd02979 into GoogleContainerTools:master Mar 23, 2020

fmotrifork mentioned this pull request Apr 3, 2020

skaffold 1.7.0 fishworks/fish-food#662

Merged