Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "use kubectl's built-in kustomize when possible" #4237

Merged
merged 1 commit into from
May 20, 2020
Merged

Revert "use kubectl's built-in kustomize when possible" #4237

merged 1 commit into from
May 20, 2020

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented May 20, 2020

Reverts #4183
Fixes #4232
Reopen #1781

@codecov
Copy link

codecov bot commented May 20, 2020 •
edited

Codecov Report

Merging #4237 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/cli.go 90.90% <ø> (-0.40%) ⬇️
pkg/skaffold/deploy/kustomize.go 74.71% <100.00%> (-1.51%) ⬇️
pkg/skaffold/util/cmd.go 47.61% <0.00%> (-4.77%) ⬇️
pkg/skaffold/server/server.go 58.57% <0.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0.00%> (+2.43%) ⬆️

@nkubala nkubala merged commit 8f04f07 into master May 20, 2020
@AndiDog AndiDog mentioned this pull request Jun 2, 2020
Closed
@nkubala nkubala deleted the revert-4183-kustomize-dep branch September 22, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@briandealwis briandealwis Awaiting requested review from briandealwis

@dgageot dgageot Awaiting requested review from dgageot

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using kustomize buildin in kubectl breaks compatibility with kustomize 3.X features
4 participants
@nkubala @tstromberg @tejal29 @googlebot