Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skaffold dependencies #5215

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

briandealwis
Copy link
Member

Update to latest stable versions. A few notes:

  • Moved to Kubectl 1.17 to track the default version used in Google Cloud SDK 322.0.0
  • Kustomize 3.9.x uses a new underlying YAML library (kyaml), and 3.8.x is based on the older api-machinery code.
  • Drops the pre-pulling of the K3D and KIND node images as it's a bit of a pain to track these images.

@briandealwis briandealwis requested a review from a team as a code owner January 9, 2021 04:35
@google-cla google-cla bot added the cla: yes label Jan 9, 2021
@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #5215 (b725c1e) into master (d439550) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5215   +/-   ##
=======================================
  Coverage   71.84%   71.84%           
=======================================
  Files         387      387           
  Lines       13939    13939           
=======================================
+ Hits        10014    10015    +1     
+ Misses       3191     3190    -1     
  Partials      734      734           
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 78.13% <0.00%> (-1.40%) ⬇️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d439550...b725c1e. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks

@briandealwis briandealwis merged commit 95092ad into GoogleContainerTools:master Jan 12, 2021
@briandealwis briandealwis deleted the update-deps branch January 12, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants