-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] fix profile activation sample #5222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5222 +/- ##
=======================================
Coverage 71.84% 71.84%
=======================================
Files 387 387
Lines 13974 13974
=======================================
Hits 10040 10040
Misses 3195 3195
Partials 739 739 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@mblottiere Hi, please excuse the late message in this already merged PR. Looking at the doc where this sample is included, it looks to me like it was correct before. In the example below:
* `profile1` is activated if `MAGIC_VAR` is 42
* `profile2` is activated if `MAGIC_VAR` is 1337 or we are running `skaffold dev` while kubecontext is set to `minikube`.
{{% readfile file="samples/profiles/activations.yaml" %}} What I see here is: if MAGIC_VAR == 1337 or (command == "dev" and kubeContext == "minikube"):
profile2 Is this simply a misunderstanding or could you kindly point out where I made the mistake? |
@ml- you are completely right 😱 this PR indeed introduced a mismatch between documentation and example. |
This reverts commit d4d0c07.
Description
This fixes a missing "-" in the profile config sample where multiple triggers are demonstrated.
User facing changes (remove if N/A)
This only impacts documentation.