Updates to ko builder design proposal to add implementation approach #6046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update resolved questions and add section for implementation approach.
Merged
Codecov Report
@@ Coverage Diff @@
## master #6046 +/- ##
==========================================
- Coverage 70.76% 70.55% -0.21%
==========================================
Files 466 468 +2
Lines 17956 18036 +80
==========================================
+ Hits 12706 12726 +20
- Misses 4320 4375 +55
- Partials 930 935 +5
Continue to review full report at Codecov.
|
Add rough steps to Approach section.
MarlonGamez
suggested changes
Jun 21, 2021
Comment on lines
+345
to
+347
| 4. Should the ko builder be the default for `skaffold init`, instead of | ||
| buildpacks, for Go apps, when there's no Dockerfile and no Bazel workspace | ||
| file? |
There was a problem hiding this comment.
I think this would be a good option. The way init treats buildpacks currently is pretty much like a catch all if we can't find a more specific builder to use for the project. So ko would be a good option to use first in this case
Co-authored-by: Marlon Gamez <marlongamez@google.com>
MarlonGamez
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking: #6041
Description
Update resolved questions and add section for implementation approach.
Specifically, document that the implementation will be a series of small PRs that can be merged one-by-one, rather than all at once when the feature is done. The PRs will not surface any new user-visible behavior until the feature is ready to be released.