Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ko): Shorter example values in config schema #6837

Merged

Conversation

halvards
Copy link
Contributor

Shorten the example values in the config schema. This fixes the issue on the skaffold.yaml reference page of the website, where long example values push the descriptions to a very narrow space on the page, making them hard to read.

Tracking: #6041

Shorten the example values in the config schema. This fixes the issue
on the `skaffold.yaml` reference page of the website, where long
example values push the description to a very narrow space on the page.

Tracking: GoogleContainerTools#6041
@halvards halvards requested a review from a team as a code owner November 11, 2021 15:12
@google-cla google-cla bot added the cla: yes label Nov 11, 2021
@halvards halvards added the kokoro:run runs the kokoro jobs on a PR label Nov 11, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #6837 (4799e94) into main (290280e) will decrease coverage by 1.34%.
The diff coverage is 64.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6837      +/-   ##
==========================================
- Coverage   70.48%   69.13%   -1.35%     
==========================================
  Files         515      547      +32     
  Lines       23150    25033    +1883     
==========================================
+ Hits        16317    17307     +990     
- Misses       5776     6564     +788     
- Partials     1057     1162     +105     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
cmd/skaffold/app/cmd/inspect_build_env.go 65.11% <75.00%> (+6.39%) ⬆️
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d7152...4799e94. Read the comment docs.

@tejal29 tejal29 merged commit b676799 into GoogleContainerTools:main Nov 11, 2021
@halvards halvards deleted the ko-shorter-config-examples branch November 12, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants