-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] feat: Add kubectl renderer #7118
[v2] feat: Add kubectl renderer #7118
Conversation
Codecov Report
@@ Coverage Diff @@
## v2-v1.36.0 #7118 +/- ##
=============================================
Coverage ? 67.61%
=============================================
Files ? 557
Lines ? 26552
Branches ? 0
=============================================
Hits ? 17954
Misses ? 7310
Partials ? 1288 Continue to review full report at Codecov.
|
if err := manifest.Write(manifests.String(), dryConfigPath, out); err != nil { | ||
return err | ||
} | ||
endTrace() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied over to GenerateHydratedManifests
in renderer/util package
cd198c6
to
aa09298
Compare
Hey @tejal29 , can we rebase this on |
aa09298
to
f457488
Compare
done! |
@tejal29 looks like there are some linter errors but besides that I think this is good ! |
done! |
8c61289
to
95de416
Compare
In PR, we are adding a kubectl renderer so user's just relying on kubectl or helm don't have to depend on kpt.
The kubectl renderer is invoked when
Description of changes
renderer.SkaffoldRenderer
torenderer.kpt.Kpt
renderer.kubectl.Kubectl
inpkg/skaffold/render/renderer/kubectl/kubectl.go
which uses the already implementedgenerated.Generator
to read k8s manifests, add labels to these manifests and write them to a hydration dirGenerateHydratedManifests
which callsgenerated.Generator.Generate
to read k8s manifests, add labels to these manifests and write them to a hydration dir. This method is used in both Kpt and Kubectl renderer.Things to do next
Render
from deployer.Deploy interface--skip-render
flag as rendering will always happenmanifests
fromv1.KubectlDeploy
section.