Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple visiting manifests and replacing images #909

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 17, 2018

This will be useful to apply more transformations to the manifests.
Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Aug 17, 2018

Codecov Report

Merging #909 into master will increase coverage by 0.57%.
The diff coverage is 96.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
+ Coverage   37.45%   38.02%   +0.57%     
==========================================
  Files          58       60       +2     
  Lines        2590     2609      +19     
==========================================
+ Hits          970      992      +22     
+ Misses       1509     1507       -2     
+ Partials      111      110       -1
Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/manifests.go 20.83% <ø> (-43.88%) ⬇️
pkg/skaffold/deploy/kubectl/images.go 100% <100%> (ø)
pkg/skaffold/deploy/kubectl/visitor.go 92.85% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d26767...47ff6d0. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thank you! LGTM

@dgageot dgageot merged commit a2e49f6 into GoogleContainerTools:master Aug 18, 2018
@dgageot dgageot deleted the manifest-visitor branch December 28, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants