Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Picker - Solid Background #106

Closed
jauyong opened this issue Nov 15, 2019 · 3 comments
Closed

Color Picker - Solid Background #106

jauyong opened this issue Nov 15, 2019 · 3 comments
Assignees
Labels
P0 Critical, drop everything

Comments

@jauyong
Copy link

jauyong commented Nov 15, 2019

Feature description

This ticket will now be for solid backgrounds only. Color picker and Gradient editing to be done in other tickets.

This ticket was taken from a row in this spreadsheet. This ticket can be used to track research and work related to porting this existing feature from the "old" editor to the "new" editor.

Color Picker

  • Setting in the right sidebar which allows choosing text and background colors.

UX Required:


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The existing color picker is ported to the new stories editor
  • The color picker is integrated into the new design

Implementation brief

QA testing instructions

Demo

Changelog entry

@pbakaus
Copy link
Contributor

pbakaus commented Nov 25, 2019

I believe we can close this one because we'll build a new colorpicker.

@pbakaus
Copy link
Contributor

pbakaus commented Nov 25, 2019

...unless we can make the existing look like the new one?

@jauyong jauyong changed the title Port Existing Color Picker Color Picker Nov 26, 2019
@swissspidy swissspidy transferred this issue from ampproject/amp-wp Jan 23, 2020
@swissspidy swissspidy added In Feature Map P0 Critical, drop everything labels Jan 23, 2020
@kmyram kmyram added this to the Sprint 22 milestone Jan 23, 2020
@swissspidy
Copy link
Collaborator

We might be able to use http://casesandberg.github.io/react-color/ to build this new color picker.

@swissspidy swissspidy self-assigned this Jan 31, 2020
@jauyong jauyong changed the title Color Picker Solid Background Feb 7, 2020
@jauyong jauyong changed the title Solid Background Color Picker - Solid Background Feb 7, 2020
@swissspidy swissspidy mentioned this issue Feb 10, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical, drop everything
Projects
None yet
Development

No branches or pull requests

4 participants