TypeScript: convert fontProvider
#12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2022 13:25
barklund
added
Type: Code Quality
barklund
commented
Dec 2, 2022
barklund
commented
Dec 2, 2022
barklund
commented
Dec 2, 2022
|
Size Change: +96 B (0%) Total Size: 2.71 MB ℹ️ View Unchanged
|
|
Plugin builds for 27d1a35 are ready 🛎️!
|
miina
reviewed
Dec 2, 2022
# Conflicts: # packages/elements/src/types/element.ts # packages/story-editor/tsconfig.json
miina
reviewed
Dec 5, 2022
miina
approved these changes
Dec 5, 2022
added 5 commits
December 8, 2022 16:43
# Conflicts: # packages/story-editor/tsconfig.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Converting the font provider to TS.
Todo
storyProvider#12652 (currently cause lint and type errors, but @miina already converted this elsewhere so just waiting for her to merge that before fixing this one).Testing Instructions
Checklist
Type: XYZlabel to the PRFixes #12663