Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Move karma-fixtures to new structure #6276

Closed
wants to merge 3 commits into from

Conversation

spacedmonkey
Copy link
Contributor

@spacedmonkey spacedmonkey commented Feb 9, 2021

Context

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

  • UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #

@spacedmonkey
Copy link
Contributor Author

Just noticed there is a ticket for this...

@spacedmonkey spacedmonkey self-assigned this Feb 9, 2021
@spacedmonkey spacedmonkey added P2 Should do soon Pod: WP & Infra Type: Infrastructure Changes impacting testing infrastructure or build tooling labels Feb 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Size Change: 0 B

Total Size: 1.43 MB

ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 876 B 0 B
assets/css/stories-dashboard.css 288 B 0 B
assets/css/web-stories-embed-block.css 615 B 0 B
assets/js/chunk-fonts-********************.js 44.5 kB 0 B
assets/js/chunk-web-stories-template-0-********************.js 11 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 11.3 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 10.9 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 10.6 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 12.7 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 7.14 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 10.1 kB 0 B
assets/js/chunk-web-stories-textset-0-********************.js 5.23 kB 0 B
assets/js/chunk-web-stories-textset-1-********************.js 6.79 kB 0 B
assets/js/chunk-web-stories-textset-2-********************.js 7.81 kB 0 B
assets/js/chunk-web-stories-textset-3-********************.js 15.3 kB 0 B
assets/js/chunk-web-stories-textset-4-********************.js 4.38 kB 0 B
assets/js/chunk-web-stories-textset-5-********************.js 5.64 kB 0 B
assets/js/chunk-web-stories-textset-6-********************.js 5.43 kB 0 B
assets/js/chunk-web-stories-textset-7-********************.js 10.3 kB 0 B
assets/js/edit-story.js 652 kB 0 B
assets/js/stories-dashboard.js 492 kB 0 B
assets/js/vendors~chunk-ffmpeg-********************.js 5.61 kB 0 B
assets/js/web-stories-activation-notice.js 74.8 kB 0 B
assets/js/web-stories-embed-block.js 17.7 kB 0 B

compressed-size-action

@swissspidy swissspidy changed the title Packages: Move karam-fixtures to new structure Packages: Move karma-fixtures to new structure Feb 9, 2021
@swissspidy swissspidy marked this pull request as draft February 9, 2021 10:53
@swissspidy swissspidy added the Status: Needs More Info Follow-up required in order to be actionable. label Feb 9, 2021
@swissspidy
Copy link
Collaborator

Note that there's no ticket for this refactor because it doesn't necessarily make sense to put this into 1 package as-is. I'd imagined this to be split up into multiple packages or refactored to live closer to the tests configuration.

Let's hold off on this for now so we can get back to the drawing board.

@swissspidy
Copy link
Collaborator

Closing in favor of #6281, which has some background on why this needs some more tinkering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Should do soon Status: Needs More Info Follow-up required in order to be actionable. Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants