Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @web-stories-wp prefix to karma packages name #8558

Merged
merged 10 commits into from
Aug 6, 2021
Merged

Add @web-stories-wp prefix to karma packages name #8558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
53a4100
Add @web-stories-wp prefix to karma packages name
mohdsayed Aug 3, 2021
87ba622
Add karma packages to package.json and update packages path
mohdsayed Aug 3, 2021
1f0eba1
Change package positions in alphabetical order
mohdsayed Aug 3, 2021
cbe3846
Update export framework key
mohdsayed Aug 3, 2021
5d89b1c
Update export module key names to be consistent with package names
mohdsayed Aug 3, 2021
3f62e8e
Update karma module key name with prefix and run npm i
mohdsayed Aug 4, 2021
a393264
Update karma-puppeteer-launcher package module key because it does no…
mohdsayed Aug 4, 2021
41f9fa5
Merge, resolve conflict with main branch and run npm i
mohdsayed Aug 4, 2021
df28e45
Merge branch 'main' of github.com:google/web-stories-wp into fix/add-…
mohdsayed Aug 6, 2021
f4b1e90
Run npm i
mohdsayed Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions karma-dashboard.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ module.exports = function (config) {
'karma-webpack',
'karma-spec-reporter',
'karma-coverage-istanbul-reporter',
require('./packages/karma-puppeteer-launcher/src/index.cjs'),
require('./packages/karma-puppeteer-client/src/index.cjs'),
require('./packages/karma-cuj-reporter/src/index.cjs'),
require('./packages/karma-failed-tests-reporter/src/index.cjs'),
require('@web-stories-wp/karma-puppeteer-launcher'),
require('@web-stories-wp/karma-puppeteer-client'),
require('@web-stories-wp/karma-cuj-reporter'),
require('@web-stories-wp/karma-failed-tests-reporter'),
],

// Frameworks to use.
// Available frameworks: https://npmjs.org/browse/keyword/karma-adapter
frameworks: ['jasmine', 'karma-puppeteer-client'],
frameworks: ['jasmine', '@web-stories-wp/karma-puppeteer-client'],
swissspidy marked this conversation as resolved.
Show resolved Hide resolved

// list of files / patterns to load in the browser
files: [
Expand Down Expand Up @@ -103,8 +103,8 @@ module.exports = function (config) {
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
reporters: [
'spec',
'failed-tests',
config.coverage && 'cuj',
'@web-stories-wp/karma-failed-tests-reporter',
config.coverage && '@web-stories-wp/karma-cuj-reporter',
config.coverage && 'coverage-istanbul',
].filter(Boolean),

Expand All @@ -123,7 +123,7 @@ module.exports = function (config) {

// start these browsers
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
browsers: ['puppeteer'],
browsers: ['karma-puppeteer-launcher'], // @web-stories-wp/karma-puppeteer-launcher package

puppeteerLauncher: {
puppeteer: {
Expand Down
16 changes: 8 additions & 8 deletions karma-edit-story.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ module.exports = function (config) {
'karma-webpack',
'karma-spec-reporter',
'karma-coverage-istanbul-reporter',
require('./packages/karma-puppeteer-launcher/src/index.cjs'),
require('./packages/karma-puppeteer-client/src/index.cjs'),
require('./packages/karma-cuj-reporter/src/index.cjs'),
require('./packages/karma-failed-tests-reporter/src/index.cjs'),
require('@web-stories-wp/karma-puppeteer-launcher'),
require('@web-stories-wp/karma-puppeteer-client'),
require('@web-stories-wp/karma-cuj-reporter'),
require('@web-stories-wp/karma-failed-tests-reporter'),
],

// Frameworks to use.
// Available frameworks: https://npmjs.org/browse/keyword/karma-adapter
frameworks: ['jasmine', 'karma-puppeteer-client'],
frameworks: ['jasmine', '@web-stories-wp/karma-puppeteer-client'],

// list of files / patterns to load in the browser
files: [
Expand Down Expand Up @@ -103,8 +103,8 @@ module.exports = function (config) {
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
reporters: [
'spec',
'failed-tests',
config.coverage && 'cuj',
'@web-stories-wp/karma-failed-tests-reporter',
config.coverage && '@web-stories-wp/karma-cuj-reporter',
config.coverage && 'coverage-istanbul',
].filter(Boolean),

Expand All @@ -123,7 +123,7 @@ module.exports = function (config) {

// start these browsers
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
browsers: ['puppeteer'],
browsers: ['karma-puppeteer-launcher'], // @web-stories-wp/karma-puppeteer-launcher package

puppeteerLauncher: {
puppeteer: {
Expand Down
Loading