Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map bounds to available data. #397

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

francescortiz
Copy link

I am integrating google-map with an elm project and at a certain point I needed to have the map bounds available without callbacks.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@francescortiz
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 8, 2017
@francescortiz
Copy link
Author

I added the option to disable fullscreen control.

…howing back a map. Marker events where being set prior proper marker initialization. This ensures the marker is initialized is the map is set.
@francescortiz
Copy link
Author

Added commit that fixes issues with Elm virtual DOM after removing the map and showing it again.

@simonh1000
Copy link

Added commit that fixes issues with Elm virtual DOM after removing the map and showing it again.

can't help thinking the Elm stuff should go in a seperate PR with a full explanation of why it was necessary and the consequences for non-Em users.

But beyond that I really hope someone gets round to reviewing this as this is an important feaure

@francescortiz
Copy link
Author

Added commit that fixes issues with Elm virtual DOM after removing the map and showing it again.

can't help thinking the Elm stuff should go in a seperate PR with a full explanation of why it was necessary and the consequences for non-Em users.

But beyond that I really hope someone gets round to reviewing this as this is an important feaure

The issue here is not related to Elm. Elm only made it surface. The situation is that markers can be added an removed to the DOM. The HTML DOM allows that and webcomponents honor that. The fix here is to check for the existence of the google.maps.Marker instance and not the existence of the google.maps.Map when we are binding/unbinding marker related events. I can open a new PR, but I thing the situation is simple enough.

bertie-wheen added a commit to bertie-wheen/google-map that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants