-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Wallet Adapter #532
Update Wallet Adapter #532
Conversation
Hi @jordansexton, I am playing around with your branch locally and am noticing some issues with connect/disconnect. If you are done with your implementation, I think it would be best to merge into a working branch rather than the Let me know if this is still a work in progress or if it is ready to merge. Thanks! |
It's ready to merge! What are the issues with connecting/disconnecting though? Anything we need to be concerned about in the library? |
I pushed some updates to this to include the latest Release Candidate of |
Because we are not using the autoConnect param, we build custom logic around maintaining wallet connection. Some of this needs to be refined so its likely on our side, not on the library. But if I find any problems, I will let you know. |
Maybe don't merge yet, I'm reworking some things in the dependencies, will push a new version. |
We're at RC 9, which looks likely to be the last RC. This PR updates GooseFX to use the latest RC. I'll follow up once we hit full release. There are no functional changes for apps with this update. It makes how wallets attach to the window more robust. |
@jordansexton - give a thumbs up if you are done and I will merge. |
Yep, I'm done! |
Hey! I think there's still a bug with mobile wallet adapter. Screen.Recording.2022-10-27.at.11.20.22.AM.movAre you, perchance, recreating the |
I'll fix this. |
@steveluscher reporting another possible issue here: i don't get redirected to https://solanamobile.com/wallets when i click on the button with an android phone that has no wallet installed and seem to just get stuck on the loading state forever Browser: firefox v99.2.0. mobilebroken.mp4On chrome v100.0.4896.127 the loading state disappears but nothing happens |
Description
This PR updates Wallet Adapter according to anza-xyz/wallet-adapter#604. This adds support for the Wallet Standard and updates Mobile Wallet Adapter.
The PR also adds yarn resolutions for
@solana/web3.js
andreact
to avoid multiple versions being resolved.How has this been tested?
Building the project locally, opening the wallet modal and seeing Backpack and Glow detected as Standard Wallets, and connecting to Backpack without an adapter.
Types of changes
Checklist:
Screenshots
Backpack and Glow detected as Standard Wallets, so they show up first.
Connected to Backpack without an adapter.