-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use BasicTask and Operations #428
Refactor to use BasicTask and Operations #428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I'm seeing a few
self.task.task
inTaskMut
andtask.task.task
in tests which I believe could be reduced by one ".task" due to Deref. - I noticed that clippy is broken in CI again:
Error: Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
and there appear to be some relevant warnings. It sure would be nice if the check would fail.
This refactors a bunch of Replica methods and the high-level Task/TaskMut to use BasicTask and commit operations to achieve their goals.
cb40df5
to
3d28e61
Compare
This doesn't work because deref only works for method calls, so
Oops, thanks for spotting that! A downside of a lot of rebasing. I have a little more work to do here and will request review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I don't entirely understand all the testing changes in the last commit but I presume they pertain to removing apply
in the next PR.
Yeah, a lot of the tests are in terms of SyncOp instead of Operation, and that gets addressed in the next PR ("Prefer Operation instead of SyncOp"). So, for this PR I've kept the SyncOp-related methods as test-only. |
This refactors a bunch of Replica methods and the high-level Task/TaskMut to use BasicTask and commit operations to achieve their goals.
I summarize all of the deprecations together in a later commit, with the breaking changes.
This is one of the "boring" bits for #372 - the next is, too, and then we get to the interesting breaking changes.