Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot needs to update src/tc/rust/Cargo.*, too #2994

Closed
djmitche opened this issue Nov 12, 2022 · 3 comments
Closed

Dependabot needs to update src/tc/rust/Cargo.*, too #2994

djmitche opened this issue Nov 12, 2022 · 3 comments
Labels
topic:devel Development-related issues (build, CI, testing, etc.) type:project-admin Project-admin issues

Comments

@djmitche
Copy link
Collaborator

This file is part of the cmake build process, and is getting left behind in the updates. This means when CMake builds it, src/tc/rust/Cargo.lock gets updated and causes spurious diffs.

@djmitche djmitche self-assigned this Nov 12, 2022
djmitche added a commit to djmitche/taskwarrior that referenced this issue Nov 12, 2022
djmitche added a commit that referenced this issue Nov 12, 2022
@djmitche
Copy link
Collaborator Author

I don't know how to fix this, so un-assigning.

(TBH, my thoughts have tended recently toward breaking TC back into its own repo..)

@djmitche djmitche removed their assignment Dec 24, 2022
@djmitche djmitche moved this to Not-3.0 in Taskwarrior Development Dec 26, 2023
@djmitche
Copy link
Collaborator Author

Taskchampion has now been broken out, so we have the following Cargo.* files:

Cargo.lock
Cargo.toml
src/tc/lib/Cargo.toml
xtask/Cargo.toml

I think this is less a CMake issue at this point, so probably easier to fix.

@djmitche djmitche added type:project-admin Project-admin issues topic:devel Development-related issues (build, CI, testing, etc.) labels May 27, 2024
@djmitche
Copy link
Collaborator Author

djmitche commented Jun 1, 2024

https://github.com/GothenburgBitFactory/taskwarrior/pull/3470/files just successfully updated Cargo.lock, which is what we want in this repo. The Taskchampion repo may also require modifications to the Cargo.toml specs for its dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:devel Development-related issues (build, CI, testing, etc.) type:project-admin Project-admin issues
Projects
Status: Done
Development

No branches or pull requests

1 participant