Only warn about .data files when showing reports #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the warning appearing in shell completion, for example.
ryneeverett
reviewed
Jun 10, 2024
Co-authored-by: ryneeverett <ryneeverett@gmail.com>
djmitche
requested review from
ryneeverett and
felixschurk
and removed request for
ryneeverett
Yeah, this was also opening the TDB2 files. I'd expect a refactor here could help. But for the moment this fixes the user-visible bug. |
felixschurk
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the warning appearing in shell completion, for example.
Fixes #3419.