Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(modal): a11y retire la liste dans la zone d'actions [DS-1257] #720

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

zellerbaptiste
Copy link
Contributor

@zellerbaptiste zellerbaptiste commented Jul 28, 2023

  • retrait de la liste <ul><li> dans la structure HTML de la zone d'action qui devient :
                    <div class="fr-modal__footer">
                        <div class="fr-btns-group fr-btns-group--right fr-btns-group--inline-reverse fr-btns-group--inline-lg fr-btns-group--icon-left">
                            <button class="fr-btn fr-icon-checkbox-circle-line fr-btn--icon-left" id="button-5462">
                                Label bouton
                            </button>
                            <button class="fr-btn fr-icon-checkbox-circle-line fr-btn--icon-left fr-btn--secondary" id="button-5463">
                                Label bouton
                            </button>
                        </div>
                    </div>

@zellerbaptiste zellerbaptiste added the correctif Quelque chose ne fonctionne pas label Jul 28, 2023
@zellerbaptiste zellerbaptiste added this to the 1.11.0 milestone Jul 28, 2023
@zellerbaptiste zellerbaptiste self-assigned this Jul 28, 2023
Copy link
Contributor

@keryanS keryanS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Les boutons doivent rester des <button> et non des <div>
  • retirer les <div> vide si non nécéssaire

@keryanS keryanS added the invalide Ne semble pas correct label Aug 28, 2023
@keryanS keryanS changed the base branch from main to dev-1.11.0 August 28, 2023 15:25
@zellerbaptiste
Copy link
Contributor Author

  • Les boutons doivent rester des <button> et non des <div>
  • retirer les <div> vide si non nécéssaire

c'est corrigé

@@ -10,15 +10,17 @@
@include margin-x(2v);
}

> li {
> li,
> div {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toujours utile ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non effectivement, je l'ai retiré

src/component/button/style/tool/_group.scss Show resolved Hide resolved
@keryanS keryanS merged commit 151acd7 into dev-1.11.0 Nov 6, 2023
5 checks passed
@keryanS keryanS deleted the fix/a11y-modal-action-btns branch November 6, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctif Quelque chose ne fonctionne pas Prêt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants