Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(header): ajustements header [DS-3601, DS-3368] #791

Merged
merged 7 commits into from
Nov 10, 2023
Merged

🐛 fix(header): ajustements header [DS-3601, DS-3368] #791

merged 7 commits into from
Nov 10, 2023

Conversation

keryanS
Copy link
Contributor

@keryanS keryanS commented Sep 15, 2023 •
edited
Loading

  • change la couleur du menu burger en $action-high-bleu-france en mobile
  • passe l'Ă©cart entre bloc marque et logo opĂ©rateur Ă  32px et l'Ă©cart entre logo opĂ©rateur et nom du site Ă  32px
  • rĂ©duit la taille de la barre de recherche Ă  96v (24rem) au lieu de 25rem
  • bloque la taille du logo opĂ©rateur Ă  8rem max (128px)
  • passe la taille du texte de la tagline en sm (14px) au lieu de md
  • passe le bouton burger en tertiaire avec border

@keryanS keryanS added correctif Quelque chose ne fonctionne pas à vérifier maj 1.10.1 labels Sep 15, 2023
@keryanS keryanS added this to the 1.11.0 milestone Sep 15, 2023
@keryanS keryanS self-assigned this Sep 15, 2023
@keryanS
Merge pull request #776 from GouvernementFR/fix/header-searchbar-size
4b8fad1 
- passe le max-width de la barre de recherche Ă  96v (384px)
@keryanS keryanS changed the title fix(header): ajustements header [DS-3601] 🐛 fix(header): ajustements header [DS-3601] Sep 15, 2023
lab9fr
lab9fr requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@lab9fr lab9fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ă  merger avec la #722 (ou plutĂŽt l'inverse) ces 2 PR traitant du mĂȘme sujet, mais pouvant entrer en conflit. Une seule PR contenant tous les changements de ces 2 tickets sera plus sĂ»r et efficace.

keryanS and others added 2 commits October 18, 2023 17:40
@keryanS
fix(header): tagline en taille sm
8d1ae7c
@zellerbaptiste
feat(header): correction menu burger (#722)
0781c73 
- feat(header): corrige la couleur et les espacements des icones menu et burger en mobile
@keryanS keryanS changed the title 🐛 fix(header): ajustements header [DS-3601] 🐛 fix(header): ajustements header [DS-3601, DS-3368] Oct 20, 2023
@keryanS keryanS requested a review from lab9fr November 9, 2023 16:15
@keryanS keryanS merged commit 7d4d272 into dev-1.11.0 Nov 10, 2023
4 checks passed
@keryanS keryanS deleted the fix/header-ajustements branch November 10, 2023 14:05
@brmzkw brmzkw mentioned this pull request Jul 11, 2024
Open
This was referenced Jul 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lab9fr lab9fr lab9fr approved these changes

@zellerbaptiste zellerbaptiste zellerbaptiste approved these changes

Assignees

@keryanS keryanS

Labels
correctif Quelque chose ne fonctionne pas maj 1.10.1 PrĂȘt
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@keryanS @lab9fr @zellerbaptiste