build(esm, cjs modules): add 'use-client' directive for esm and cjs m… #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules Users of nextjs have to add "use client" whenever they use sgds components and it becomes a hassle as they have create a file and wrap our components with 'use client'. To add 'use-client' directive during build. Client side react users are unaffected, and should be unaffected by this update.
remove use client from nextjs tester app remove usage of subcomponents from nextjs app update exports of subcomponents in src folder
clukhei
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Removed "use client" from nextjs page.tsx file to test the new "use client" directive defined at the top of the components file.
added exports of individual subcomponents due to upstream issue of nextjs vercel/next.js#51593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket SGDS-668
React components are client side components as it uses hook (useContext and in future useId).
Users of nextjs will have to add "use client" whenever they use our components and it becomes a hassle as they have create a file and wrap our components with 'use client'. This is ok for big components that they need to customize and wrap over, but for smaller components like button which they expect to use out of the hood , its quite a hassle.
Client side react users are unaffected, and should be unaffected by this update.
Solution found at https://www.misha.wtf/blog/rollup-server-components
Tested on cypress e2e apps to be working.