Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path symlinks to create ostree layout #3

Merged
merged 8 commits into from
Oct 1, 2023
Merged

Use absolute path symlinks to create ostree layout #3

merged 8 commits into from
Oct 1, 2023

Conversation

wegel
Copy link
Contributor

@wegel wegel commented Oct 1, 2023

Otherwise non-root directories (eg, /usr/local) won't work.

Otherwise non-root directories (eg, /usr/local) won't work.
Copy link
Owner

@GrabbenD GrabbenD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing and great catch:

[root@ostree ~]# readlink /usr/local
var/usrlocal
[root@ostree ~]# cd /usr/local
-bash: cd: /usr/local: No such file or directory

In spirit of keeping the same symlink syntax as other Linux distros in /, let's only fix the faulty symlink:

Default (Arch Linux)

bin -> usr/bin
boot
dev
etc
home
lib -> usr/lib
lib64 -> usr/lib
mnt
opt
proc
root
run
sbin -> usr/bin
srv
sys
tmp
usr
var

OSTREE_CREATE_LAYOUT

bin -> usr/bin
boot
dev
etc
home -> var/home
kuk
lib -> usr/lib
lib64 -> usr/lib
mnt -> var/mnt
opt -> var/opt
ostree -> sysroot/ostree
proc
root -> var/roothome
run
sbin -> usr/bin
srv -> var/srv
sys
sysroot
tmp
usr
var

Proposed change

bin -> usr/bin
boot
dev
home -> /var/home
lib -> usr/lib
lib64 -> usr/lib
mnt -> /var/mnt
opt -> /var/opt
ostree -> /sysroot/ostree
proc
root -> /var/roothome
run
sbin -> usr/bin
srv -> /var/srv
sys
sysroot
tmp
usr
var

ostree.sh Outdated Show resolved Hide resolved
ostree.sh Outdated Show resolved Hide resolved
ostree.sh Outdated Show resolved Hide resolved
ostree.sh Outdated Show resolved Hide resolved
ostree.sh Outdated Show resolved Hide resolved
ostree.sh Outdated Show resolved Hide resolved
ostree.sh Outdated Show resolved Hide resolved
@GrabbenD GrabbenD merged commit 91c0555 into GrabbenD:main Oct 1, 2023
@wegel wegel deleted the fix/absolute-symlinks-ostree-layout branch October 2, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants