GNOME Shell theming support #679

tfuxu · 2022-12-23T01:50:04Z

Description

THE SHELL THEMING IS REAL!!!

This is it, Shell theming finally comes to Gradience. This means that we only need to add support to additional 420 frameworks and terminal emulators for a "complete GNOME themeing beauty" (sic).

But in all seriousness, this PR brings up shell theming support for GNOME Shell versions 43 and 42. It is WIP, but can be tested already with a majority of available presets (~~excluding light presets~~ Light presets support was significantly improved in commit 7e9ac2c and can be tested as well).

This PR also introduces a new concept of Theme Engines and improves designs of Theming tab and Preferences window, to make them more readable and expandable.

To-do list:

Screenshots

Full desktop view with a theme that goes hard

OSD widgets properly themed!? No way!

Nice

Fixes #618 and GradienceTeam/Plugins#11

Type of change

Bugfix (Change which fixes a issue)
New feature (Change which adds new functionality)
Enhancement (Change which slightly improves existing code)
Breaking change (This change will introduce incompatibility with existing functionality)

Warning This PR will require a change in documentation

Changelog

Changed Monet section name to Theming
GradienceOptionRow widget is now more flexible
Make Theming section more modular
Added new group in Theming section
Renamed settings_schema to preset_schema and moved to frontend/schemas subdir
Added new GNOME Shell option in GradienceAppTypeDialog view
Created new model module ShellTheme with available manipulation functions

Testing

I have tested my changes and verified that they work as expected

How to test the changes

Clone this repo with --recurse-submodules flag: git clone --recurse-submodules https://github.com/GradienceTeam/Gradience.git and switch branches to get into this PR: git checkout shell-theming

Make sure you have User Themes GNOME extension installed (and enabled!), which you should as it is an built-in plugin, but check it nonetheless.

Load a preset you want to generate a theme from. Click on Theming tab in main window, choose in Preset Variant row which color variant is your preset and click Apply button in Shell Engine.

~~Open User Themes extension settings and check (or recheck) gradience-shell theme.~~ Not needed as of commit 6493453

This commit brings up initial support for GNOME Shell 43 and 42 theming. Additions in this commit: * Shell theme generation from preset variables * Custom preferences group in Theming section (non-functional atm) * Not much else Snippets of code are based on code from `material-you-theme` GNOME extension licensed under the terms of the GNU GPLv3 license.

daudix · 2022-12-23T04:44:40Z

LFG!!! 🚀 🚀 🚀

(I love the meme'ness of this PR)

0xMRTT · 2022-12-29T20:31:14Z

Amazing 😎🎉🚀

Thank you very much!

Neon-44 · 2022-12-30T18:17:05Z

that is fucking awesome and i love it 🥳

also: what extension did you use to move the notification panel to the right?

daudix · 2022-12-30T19:39:31Z

@Neon-44

what extension did you use to move the notification panel to the right?

I think this can be done using Just Perfection

Signed-off-by: tfuxu <73042332+tfuxu@users.noreply.github.com>

daudix · 2023-01-09T20:18:12Z

Why exactly it can't run in flatpak?

tfuxu · 2023-01-09T20:46:35Z

Why exactly it can't run in flatpak?

$ flatpak run com.github.GradienceTeam.Gradience

(process:2): GLib-GIO-ERROR **: 21:44:24.769: Settings schema 'org.gnome.shell.extensions.user-theme' is not installed
** Crash **

Neon-44 · 2023-01-10T21:15:05Z

can't be fixed with flatseal?

tfuxu · 2023-01-10T23:27:05Z

can't be fixed with flatseal?

Unfortunately, it seems that when Flatpak moved from using DConf for overrides to keyfiles, they disallowed accessing host DConf, so we can't fix this with Flatseal (or overrides more generally speaking).

Full commit changelog: * refactored `main_window` module * removed 'GNOME Shell' option from `AppTypeDialog` widget * changed Shell theming section design, now it's a single `ExpandRow` widget in `PreferencesGroup` parent with an `ActionRow` with a button to 'Custom Shell Colors' window as a child * splitted most widget groups in `main_window` module into an external modules * disabled `get_default_wallpaper` function in `main_window` module * updated POTFILES

tfuxu · 2023-01-11T23:51:59Z

Quick summary of a commit `b48add9`

Updated Theming tab design:

New Custom Theme Color customization window:

daudix · 2023-01-11T23:53:55Z

Alright, now the UI looks a bit drunk, we now have the colors and theming section, we should do something with this later

tfuxu · 2023-01-12T20:02:26Z

@0xMRTT
Could you create a repository for submodules? Just name it Submodules, as we might later use it for other themes that require variables injection.

talwat · 2023-01-16T13:46:55Z

Why exactly it can't run in flatpak?

$ flatpak run com.github.GradienceTeam.Gradience

(process:2): GLib-GIO-ERROR **: 21:44:24.769: Settings schema 'org.gnome.shell.extensions.user-theme' is not installed
** Crash **

Is there a planned way to get around this?

tfuxu · 2023-01-16T16:52:33Z

Is there a planned way to get around this?

Well, I will need to come up with something eventually, because Flatpak users are our biggest demographic, but currently I have no idea how to make it work.

daudix · 2023-01-16T16:58:07Z

Maybe system bus access can help?

Can't test myself rn

tfuxu · 2023-01-16T17:29:25Z

Maybe system bus access can help?

You might be onto something, maybe not with system bus, because DConf holds its D-bus calls in session bus, but if it actually allows accessing host DConf that way, we might be able to make use of it here.

UserrX · 2023-04-30T21:10:14Z

Created a github-account just to make this comment :)... I really want to try this out, but I can't get the right version of Gradience or so it seems. I installed gradience-git with yay in Arch and then followed the steps above, but no luck. I don't see the 'Theming' menu nor the 'enable shell theming switch'.

Can someone help me out and do a step by step how to get this version so I can try out the shell theming? I am not new to Linux but not a rockstar either...

* remove old `flatpak_gsettings` module

* replace common.run_command function with subprocess.GradienceSubprocess in `gnome` module functions

tfuxu · 2023-04-30T21:45:42Z

@UserrX
gradience-git package won't have (yet) changes from here, because it fetches source code from main branch, and this PR is in shell-theming branch.

You need to build Gradience manually from source if you want it installed directly on your system (and not as a Flatpak package). To do that, clone repository, checkout to shell-theming branch and setup submodules:

git clone https://github.com/GradienceTeam/Gradience.git
cd Gradience
git fetch
git checkout shell-theming
git submodule update --init --recursive

If you installed gradience-git using yay or other AUR manager, then you don't need to install dependencies.

If not, type this:

pip install -r requirements.txt

and:

sudo pacman -S meson ninja blueprint-compiler python-gobject libsoup libadwaita

Finally, you need to setup build directory and use ninja to "compile" Gradience:

meson setup builddir
meson configure builddir -Dprefix=/usr/local
sudo ninja -C builddir install

UserrX · 2023-05-01T06:27:38Z

Thank you so much for writing the steps out @tfuxu! That worked great ánd helped me to understand a bit better what is going on.

tfuxu · 2023-05-01T12:38:27Z

No problem, glad I could help. We might merge this PR today (if I finish adding frontend code for checks), or tomorrow, so pretty soon you'll be able to use gradience-git package again with Shell theming available.

UserrX · 2023-05-01T16:37:59Z

No problem, glad I could help. We might merge this PR today (if I finish adding frontend code for checks), or tomorrow, so pretty soon you'll be able to use gradience-git package again with Shell theming available.

Would you mind telling me what I have to do when the merge happens?

tfuxu · 2023-05-01T18:29:38Z

I never used -git packages, but I guess that you'll only need to uninstall manually installed Gradience and install gradience-git using any AUR manager.

To uninstall manually installed Gradience, go to Gradience/ folder (if you haven't removed it yet) and type this:

sudo ninja -C builddir uninstall

daudix · 2023-05-02T20:02:16Z

Something is wrong, I can feel it…

daudix · 2023-05-02T20:31:38Z

For some reason quick settings menus are not recolored

tfuxu · 2023-05-02T21:39:48Z

Probably something new in 44, it looks normal in 43

I'll restore them before 0.8.0, but I would like to have them for now removed while setting custom panel color isn't working properly.

tfuxu · 2023-05-04T10:30:47Z

Okay, everything that was planned for this PR is implemented, and most of the issues have been fixed, so I think we should be ready for merge.
CC @daudix-UFO @0xMRTT Should we merge this now?

daudix · 2023-05-04T12:09:19Z

Yes!

tfuxu · 2023-05-04T13:41:16Z

@0xMRTT Remember to add submodules fetching to gradience-git package

UserrX · 2023-05-04T17:44:02Z

@0xMRTT Remember to add submodules fetching to gradience-git package

Yes. I think this causes an issue at the moment. I removed with the command you suggested, but I'm having issues with installing from gradience-git. Actually Gnome Builder doesn't work either. There is a pygobject dependency error.

I've followed the steps you laid out above, skipping the checkout, thinking that would give me a working install again. Everything seems to install fine, but Gradience won't load.

tfuxu added 2 commits December 23, 2022 02:07

Merge branch 'main' into shell-theming

5060a2d

tfuxu added type/feature area/gnome-shell labels Dec 23, 2022

tfuxu added this to the 0.8.0 milestone Dec 23, 2022

tfuxu added 2 commits December 25, 2022 23:41

Merge branch 'main' into shell-theming

b49b1ff

Merge branch 'main' into shell-theming

969a1f3

tfuxu added 2 commits January 4, 2023 20:46

Merge branch 'main' into shell-theming

fb9e1a5

Signed-off-by: tfuxu <73042332+tfuxu@users.noreply.github.com>

Merge branch 'main' into shell-theming

d3f9d28

Signed-off-by: tfuxu <73042332+tfuxu@users.noreply.github.com>

tfuxu added 2 commits January 11, 2023 16:24

Merge branch 'main' into shell-theming

dc7e91e

views/main_window: fix missing variable error

aaafa56

tfuxu added the status/wip Work in progress label Jan 13, 2023

Merge branch 'main' into shell-theming

29eac26

tfuxu mentioned this pull request Jan 15, 2023

feat: GNOME Shell Theming #618

Closed

1 task

tfuxu added 6 commits April 30, 2023 23:20

utils/gsettings: move flatpak_gsettings code to gsettings module

1652834

shell-engine: use FlatpakGSettings from gsettings module

60568ed

* remove old `flatpak_gsettings` module

utils/gnome: create is_shell_ext_installed helper function

4441b06

* replace common.run_command function with subprocess.GradienceSubprocess in `gnome` module functions

backend/utils/common: remove run_command function

4768447

fix: print out theming warning only once at top of gtk.css

320cb2e

backend/exceptions: create base Gradience exception class

6c1e5ef

tfuxu added 4 commits May 1, 2023 17:12

monet-engine: use Adw.ButtonContent for file chooser button

1165bd3

shell-engine: make reset_theme function async

d8c6cf5

Merge branch 'main' into shell-theming

4609eb7

po: add missing strings

83ceb54

tfuxu added 2 commits May 1, 2023 23:34

shell-engine: add checks for User Themes extension

f854c50

shell-engine: add gnome checks to CLI

3ba1ce1

shell-engine: Remove blocking panel color definitions for now

611140d

I'll restore them before 0.8.0, but I would like to have them for now removed while setting custom panel color isn't working properly.

tfuxu merged commit e412a2c into main May 4, 2023

tfuxu deleted the shell-theming branch May 4, 2023 13:24

Arcitec mentioned this pull request May 22, 2023

Have you considered porting all themes to Gradience? lassekongo83/adw-colors#22

Closed

sidevesh mentioned this pull request Jul 10, 2023

bug: Theming issues with panels in gnome shell #801

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GNOME Shell theming support #679

GNOME Shell theming support #679

tfuxu commented Dec 23, 2022 •

edited

Loading

daudix commented Dec 23, 2022

0xMRTT commented Dec 29, 2022

Neon-44 commented Dec 30, 2022 •

edited

Loading

daudix commented Dec 30, 2022 •

edited

Loading

daudix commented Jan 9, 2023

tfuxu commented Jan 9, 2023

Neon-44 commented Jan 10, 2023

tfuxu commented Jan 10, 2023 •

edited

Loading

tfuxu commented Jan 11, 2023 •

edited

Loading

daudix commented Jan 11, 2023 •

edited

Loading

tfuxu commented Jan 12, 2023

talwat commented Jan 16, 2023

tfuxu commented Jan 16, 2023

daudix commented Jan 16, 2023

tfuxu commented Jan 16, 2023

UserrX commented Apr 30, 2023

tfuxu commented Apr 30, 2023

UserrX commented May 1, 2023 •

edited

Loading

tfuxu commented May 1, 2023

UserrX commented May 1, 2023

tfuxu commented May 1, 2023

daudix commented May 2, 2023

daudix commented May 2, 2023

tfuxu commented May 2, 2023 •

edited

Loading

tfuxu commented May 4, 2023

daudix commented May 4, 2023

tfuxu commented May 4, 2023

UserrX commented May 4, 2023 •

edited

Loading

GNOME Shell theming support #679

GNOME Shell theming support #679

Conversation

tfuxu commented Dec 23, 2022 • edited Loading

Description

THE SHELL THEMING IS REAL!!!

To-do list:

Screenshots

Type of change

Changelog

Testing

How to test the changes

daudix commented Dec 23, 2022

0xMRTT commented Dec 29, 2022

Neon-44 commented Dec 30, 2022 • edited Loading

daudix commented Dec 30, 2022 • edited Loading

daudix commented Jan 9, 2023

tfuxu commented Jan 9, 2023

Neon-44 commented Jan 10, 2023

tfuxu commented Jan 10, 2023 • edited Loading

tfuxu commented Jan 11, 2023 • edited Loading

Quick summary of a commit b48add9

daudix commented Jan 11, 2023 • edited Loading

tfuxu commented Jan 12, 2023

talwat commented Jan 16, 2023

tfuxu commented Jan 16, 2023

daudix commented Jan 16, 2023

tfuxu commented Jan 16, 2023

UserrX commented Apr 30, 2023

tfuxu commented Apr 30, 2023

UserrX commented May 1, 2023 • edited Loading

tfuxu commented May 1, 2023

UserrX commented May 1, 2023

tfuxu commented May 1, 2023

daudix commented May 2, 2023

daudix commented May 2, 2023

tfuxu commented May 2, 2023 • edited Loading

tfuxu commented May 4, 2023

daudix commented May 4, 2023

tfuxu commented May 4, 2023

UserrX commented May 4, 2023 • edited Loading

tfuxu commented Dec 23, 2022 •

edited

Loading

Neon-44 commented Dec 30, 2022 •

edited

Loading

daudix commented Dec 30, 2022 •

edited

Loading

tfuxu commented Jan 10, 2023 •

edited

Loading

tfuxu commented Jan 11, 2023 •

edited

Loading

Quick summary of a commit `b48add9`

daudix commented Jan 11, 2023 •

edited

Loading

UserrX commented May 1, 2023 •

edited

Loading

tfuxu commented May 2, 2023 •

edited

Loading

UserrX commented May 4, 2023 •

edited

Loading